Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: custom domain with fallback ordinal scale #757

Merged
merged 3 commits into from
Jul 21, 2020
Merged

fix: custom domain with fallback ordinal scale #757

merged 3 commits into from
Jul 21, 2020

Conversation

nickofthyme
Copy link
Collaborator

Summary

fix #756

Fix bug related to ordinal scale fallback when using a custom domain

@nickofthyme nickofthyme requested a review from markov00 July 20, 2020 17:36
@nickofthyme nickofthyme added :data Data/series/scales related issue bug Something isn't working labels Jul 20, 2020
markov00
markov00 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, I think we should add an integration test for that

@nickofthyme nickofthyme merged commit 142c3df into elastic:master Jul 21, 2020
@nickofthyme nickofthyme deleted the fix-custom-domain branch July 21, 2020 19:00
markov00 pushed a commit that referenced this pull request Jul 21, 2020
@semantic-release-bot
chore(release): 20.0.1 [skip ci]
7fc4015 
## [20.0.1](v20.0.0...v20.0.1) (2020-07-21)

### Bug Fixes

* custom domain error with fallback ordinal scale ([#757](#757)) ([142c3df](142c3df)), closes [#756](#756)
@markov00
Copy link
Member

🎉 This PR is included in version 20.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jul 21, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 20.0.1 [skip ci]
794c556 
## [20.0.1](elastic/elastic-charts@v20.0.0...v20.0.1) (2020-07-21)

### Bug Fixes

* custom domain error with fallback ordinal scale ([opensearch-project#757](elastic/elastic-charts#757)) ([a78fb4f](elastic/elastic-charts@a78fb4f)), closes [opensearch-project#756](elastic/elastic-charts#756)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working :data Data/series/scales related issue released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fallback scale should not use custom domain
2 participants
@nickofthyme @markov00